Add multisig_xpub_magic option to GetPublicKey #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkozlik
added
core
|
andrewkozlik
force-pushed
the
andrewkozlik/multisig
branch
from
0328d4c
to
33689d5
Compare
|
andrewkozlik
force-pushed
the
andrewkozlik/multisig
branch
2 times, most recently
from
48c04ce
to
9c8dd25
Compare
andrewkozlik
force-pushed
the
andrewkozlik/multisig
branch
from
9c8dd25
to
3266960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2658
Adds a bool option
multisig_xpub_magictoGetPublicKey, so that Trezor displays XPUBs with the correct SLIP-132 prefix (XPUB magic) for SegWit v0 multisig accounts.See also Slack discussion about the solution: https://satoshilabs.slack.com/archives/C02V2PSDNA2/p1669125576505009
This PR unifies the xpub_magic handling for
get_public_key()andget_address(). Each function behaved a bit differently when the required SegWitcoin.xpub_magic_*attribute was not defined. One raised an exception while the other fell back to plain oldcoin.xpub_magic. However, from what I can tell, cointool.py guarantees that the attributes are defined ifcoin.segwitis true. So I feel that the simplest solution is to fall back.